Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed VideoRecorder crash when passing fps #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Fixed VideoRecorder crash when passing fps #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/test_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@
from torchrl.envs.utils import check_env_specs, MarlGroupMapType, step_mdp
from torchrl.modules import GRUModule, LSTMModule, MLP, ProbabilisticActor, TanhNormal
from torchrl.modules.utils import get_primers_from_module
from torchrl.record.recorder import VideoRecorder

if os.getenv("PYTORCH_TEST_FBCODE"):
from pytorch.rl.test._utils_internal import ( # noqa
Expand Down Expand Up @@ -13978,6 +13979,14 @@ def test_transform_inverse(self):
raise pytest.skip("Tested elsewhere")


class TestVideoRecorder:
# TODO: add more tests
def test_can_init_with_fps(self):
recorder = VideoRecorder(None, None, fps=30)

assert recorder is not None


if __name__ == "__main__":
args, unknown = argparse.ArgumentParser().parse_known_args()
pytest.main([__file__, "--capture", "no", "--exitfirst"] + unknown)
2 changes: 1 addition & 1 deletion torchrl/record/recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def __init__(
video_kwargs = {}
video_kwargs.update(kwargs)
if fps is not None:
self.video_kwargs["fps"] = fps
video_kwargs["fps"] = fps
self.video_kwargs = video_kwargs
self.iter = 0
self.skip = skip
Expand Down