[BugFix] Tree make node fix #2839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2839
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 27 PendingAs of commit 10981d4 with merge base 73c7b0a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@rolo you just need to run the linter |
Done. Apologies. I did see them flagged, but as they were in unrelated files I thought I should leave them. |
vmoens
pushed a commit
that referenced
this pull request
Mar 8, 2025
(cherry picked from commit ba8be9c)
vmoens
pushed a commit
that referenced
this pull request
Mar 10, 2025
(cherry picked from commit ba8be9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calling Tree.make_node was resulting in
TypeError: Tree.__init__() got an unexpected keyword argument 'node'.It looks as though it's because of a kwarg being passed as "node" instead of "node_data" at the end of the function so I renamed it. I added some tests to show this but it seemed a bit over the top to keep 3 separate tests for such a small thing so I combined them afterwards.
Types of changes
Checklist
Thanks :)