Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BugFix] Fix gc import #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

[BugFix] Fix gc import #2862

merged 1 commit into from
Mar 20, 2025

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Mar 20, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Update
2936e40 
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Mar 20, 2025
[BugFix] Fix gc import
c64a042 
ghstack-source-id: b732d4f
Pull Request resolved: #2862
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2862

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@vmoens vmoens added the bug Something isn't working label Mar 20, 2025
@vmoens vmoens linked an issue Mar 20, 2025 that may be closed by this pull request
[BUG] "NameError: name 'gc' is not defined" in "Using Replay Buffers" tutorial #2860
Closed
3 tasks
@vmoens vmoens added the documentation Improvements or additions to documentation label Mar 20, 2025
@vmoens vmoens merged commit 2936e40 into gh/vmoens/123/base Mar 20, 2025
36 of 55 checks passed
vmoens pushed a commit that referenced this pull request Mar 20, 2025
[BugFix] Fix gc import
a183f02 
ghstack-source-id: b732d4f
Pull Request resolved: #2862
@vmoens vmoens deleted the gh/vmoens/123/head branch March 20, 2025 00:42
@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}18$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.6348s 0.5395s 1.8537 Ops/s 1.8737 Ops/s $\color{#d91a1a}-1.07\%$
test_transformed 1.1637s 1.0622s 0.9415 Ops/s 0.9437 Ops/s $\color{#d91a1a}-0.23\%$
test_serial 1.5515s 1.5429s 0.6481 Ops/s 0.6416 Ops/s $\color{#35bf28}+1.02\%$
test_parallel 1.4290s 1.3310s 0.7513 Ops/s 0.7520 Ops/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[True-True-True-True-True] 0.2912ms 34.1036μs 29.3224 KOps/s 29.6817 KOps/s $\color{#d91a1a}-1.21\%$
test_step_mdp_speed[True-True-True-True-False] 57.8080μs 19.7100μs 50.7356 KOps/s 51.0934 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[True-True-True-False-True] 41.8280μs 19.0851μs 52.3968 KOps/s 53.2195 KOps/s $\color{#d91a1a}-1.55\%$
test_step_mdp_speed[True-True-True-False-False] 40.5550μs 11.0460μs 90.5304 KOps/s 92.1207 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[True-True-False-True-True] 68.1970μs 37.0433μs 26.9954 KOps/s 27.8665 KOps/s $\color{#d91a1a}-3.13\%$
test_step_mdp_speed[True-True-False-True-False] 49.9330μs 22.1525μs 45.1416 KOps/s 45.8557 KOps/s $\color{#d91a1a}-1.56\%$
test_step_mdp_speed[True-True-False-False-True] 51.9960μs 21.7296μs 46.0201 KOps/s 47.7443 KOps/s $\color{#d91a1a}-3.61\%$
test_step_mdp_speed[True-True-False-False-False] 42.2790μs 13.2798μs 75.3025 KOps/s 76.5647 KOps/s $\color{#d91a1a}-1.65\%$
test_step_mdp_speed[True-False-True-True-True] 85.6390μs 39.7939μs 25.1295 KOps/s 26.0576 KOps/s $\color{#d91a1a}-3.56\%$
test_step_mdp_speed[True-False-True-True-False] 0.1038ms 24.1550μs 41.3992 KOps/s 41.6562 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[True-False-True-False-True] 59.7910μs 21.5585μs 46.3854 KOps/s 47.3830 KOps/s $\color{#d91a1a}-2.11\%$
test_step_mdp_speed[True-False-True-False-False] 39.1620μs 13.3032μs 75.1699 KOps/s 76.5622 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[True-False-False-True-True] 88.0540μs 41.3374μs 24.1912 KOps/s 24.8744 KOps/s $\color{#d91a1a}-2.75\%$
test_step_mdp_speed[True-False-False-True-False] 65.0310μs 26.4426μs 37.8178 KOps/s 37.9994 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-False-False-False-True] 47.8190μs 23.7746μs 42.0617 KOps/s 42.9935 KOps/s $\color{#d91a1a}-2.17\%$
test_step_mdp_speed[True-False-False-False-False] 52.3570μs 15.3245μs 65.2548 KOps/s 65.9469 KOps/s $\color{#d91a1a}-1.05\%$
test_step_mdp_speed[False-True-True-True-True] 76.5520μs 39.1786μs 25.5241 KOps/s 26.1518 KOps/s $\color{#d91a1a}-2.40\%$
test_step_mdp_speed[False-True-True-True-False] 70.1000μs 24.2415μs 41.2515 KOps/s 41.6805 KOps/s $\color{#d91a1a}-1.03\%$
test_step_mdp_speed[False-True-True-False-True] 64.9110μs 24.6642μs 40.5446 KOps/s 41.2395 KOps/s $\color{#d91a1a}-1.68\%$
test_step_mdp_speed[False-True-True-False-False] 51.7960μs 14.6507μs 68.2563 KOps/s 69.3370 KOps/s $\color{#d91a1a}-1.56\%$
test_step_mdp_speed[False-True-False-True-True] 83.9760μs 41.5300μs 24.0790 KOps/s 25.0938 KOps/s $\color{#d91a1a}-4.04\%$
test_step_mdp_speed[False-True-False-True-False] 2.4071ms 26.7390μs 37.3985 KOps/s 38.0320 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[False-True-False-False-True] 53.3190μs 26.7557μs 37.3752 KOps/s 38.4669 KOps/s $\color{#d91a1a}-2.84\%$
test_step_mdp_speed[False-True-False-False-False] 52.5280μs 16.8815μs 59.2365 KOps/s 60.1477 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[False-False-True-True-True] 79.9790μs 43.9065μs 22.7757 KOps/s 23.5210 KOps/s $\color{#d91a1a}-3.17\%$
test_step_mdp_speed[False-False-True-True-False] 58.3480μs 28.5846μs 34.9838 KOps/s 35.1327 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-False-True-False-True] 58.8990μs 26.3866μs 37.8980 KOps/s 38.8722 KOps/s $\color{#d91a1a}-2.51\%$
test_step_mdp_speed[False-False-True-False-False] 61.5250μs 16.6465μs 60.0728 KOps/s 60.5044 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[False-False-False-True-True] 0.1039ms 45.9261μs 21.7741 KOps/s 22.4814 KOps/s $\color{#d91a1a}-3.15\%$
test_step_mdp_speed[False-False-False-True-False] 90.3270μs 30.4031μs 32.8914 KOps/s 32.7648 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-False-False-False-True] 62.7360μs 28.4168μs 35.1905 KOps/s 36.1912 KOps/s $\color{#d91a1a}-2.77\%$
test_step_mdp_speed[False-False-False-False-False] 49.7130μs 18.6643μs 53.5783 KOps/s 53.8135 KOps/s $\color{#d91a1a}-0.44\%$
test_values[generalized_advantage_estimate-True-True] 10.0774ms 9.5997ms 104.1695 Ops/s 99.7710 Ops/s $\color{#35bf28}+4.41\%$
test_values[vec_generalized_advantage_estimate-True-True] 29.8034ms 24.5119ms 40.7965 Ops/s 38.2678 Ops/s $\textbf{\color{#35bf28}+6.61\%}$
test_values[td0_return_estimate-False-False] 0.2537ms 0.1839ms 5.4379 KOps/s 4.9087 KOps/s $\textbf{\color{#35bf28}+10.78\%}$
test_values[td1_return_estimate-False-False] 24.6524ms 24.0894ms 41.5121 Ops/s 39.9532 Ops/s $\color{#35bf28}+3.90\%$
test_values[vec_td1_return_estimate-False-False] 26.2240ms 24.4653ms 40.8743 Ops/s 38.1386 Ops/s $\textbf{\color{#35bf28}+7.17\%}$
test_values[td_lambda_return_estimate-True-False] 35.4121ms 34.8437ms 28.6996 Ops/s 28.0424 Ops/s $\color{#35bf28}+2.34\%$
test_values[vec_td_lambda_return_estimate-True-False] 27.1956ms 24.4147ms 40.9589 Ops/s 38.3281 Ops/s $\textbf{\color{#35bf28}+6.86\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.8825ms 8.4405ms 118.4764 Ops/s 115.3558 Ops/s $\color{#35bf28}+2.71\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.4733ms 1.9700ms 507.6186 Ops/s 533.3362 Ops/s $\color{#d91a1a}-4.82\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4939ms 0.3728ms 2.6823 KOps/s 2.6504 KOps/s $\color{#35bf28}+1.20\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 46.5563ms 42.0738ms 23.7678 Ops/s 21.7503 Ops/s $\textbf{\color{#35bf28}+9.28\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.4232ms 3.4959ms 286.0497 Ops/s 287.1428 Ops/s $\color{#d91a1a}-0.38\%$
test_dqn_speed[False-None] 6.0846ms 1.4676ms 681.3731 Ops/s 697.8357 Ops/s $\color{#d91a1a}-2.36\%$
test_dqn_speed[False-backward] 2.0883ms 1.9572ms 510.9213 Ops/s 528.1300 Ops/s $\color{#d91a1a}-3.26\%$
test_dqn_speed[True-None] 0.8246ms 0.5770ms 1.7332 KOps/s 1.7481 KOps/s $\color{#d91a1a}-0.85\%$
test_dqn_speed[True-backward] 1.0466ms 0.9968ms 1.0032 KOps/s 1.0015 KOps/s $\color{#35bf28}+0.18\%$
test_dqn_speed[reduce-overhead-None] 0.7819ms 0.5775ms 1.7315 KOps/s 1.7221 KOps/s $\color{#35bf28}+0.55\%$
test_dqn_speed[reduce-overhead-backward] 1.1499ms 1.0187ms 981.6084 Ops/s 1.0026 KOps/s $\color{#d91a1a}-2.09\%$
test_ddpg_speed[False-None] 3.9224ms 3.0399ms 328.9555 Ops/s 336.8651 Ops/s $\color{#d91a1a}-2.35\%$
test_ddpg_speed[False-backward] 4.2838ms 4.1624ms 240.2442 Ops/s 242.9216 Ops/s $\color{#d91a1a}-1.10\%$
test_ddpg_speed[True-None] 2.0417ms 1.4732ms 678.7932 Ops/s 689.2576 Ops/s $\color{#d91a1a}-1.52\%$
test_ddpg_speed[True-backward] 2.4342ms 2.3848ms 419.3200 Ops/s 377.1449 Ops/s $\textbf{\color{#35bf28}+11.18\%}$
test_ddpg_speed[reduce-overhead-None] 1.9560ms 1.4690ms 680.7527 Ops/s 683.5968 Ops/s $\color{#d91a1a}-0.42\%$
test_ddpg_speed[reduce-overhead-backward] 3.0037ms 2.4109ms 414.7802 Ops/s 416.5404 Ops/s $\color{#d91a1a}-0.42\%$
test_sac_speed[False-None] 10.0641ms 8.2340ms 121.4473 Ops/s 120.7482 Ops/s $\color{#35bf28}+0.58\%$
test_sac_speed[False-backward] 11.7677ms 11.0809ms 90.2455 Ops/s 89.4153 Ops/s $\color{#35bf28}+0.93\%$
test_sac_speed[True-None] 2.8699ms 2.6049ms 383.8864 Ops/s 370.5195 Ops/s $\color{#35bf28}+3.61\%$
test_sac_speed[True-backward] 4.7228ms 4.4170ms 226.3993 Ops/s 217.1654 Ops/s $\color{#35bf28}+4.25\%$
test_sac_speed[reduce-overhead-None] 2.9938ms 2.6275ms 380.5886 Ops/s 362.8708 Ops/s $\color{#35bf28}+4.88\%$
test_sac_speed[reduce-overhead-backward] 4.9257ms 4.4189ms 226.3014 Ops/s 219.5559 Ops/s $\color{#35bf28}+3.07\%$
test_redq_speed[False-None] 15.8497ms 13.4475ms 74.3630 Ops/s 71.4282 Ops/s $\color{#35bf28}+4.11\%$
test_redq_speed[False-backward] 26.2109ms 22.9901ms 43.4971 Ops/s 41.8285 Ops/s $\color{#35bf28}+3.99\%$
test_redq_speed[True-None] 8.8975ms 7.6949ms 129.9567 Ops/s 125.9608 Ops/s $\color{#35bf28}+3.17\%$
test_redq_speed[True-backward] 16.2100ms 15.2389ms 65.6213 Ops/s 63.5903 Ops/s $\color{#35bf28}+3.19\%$
test_redq_speed[reduce-overhead-None] 8.1907ms 7.3809ms 135.4854 Ops/s 128.7420 Ops/s $\textbf{\color{#35bf28}+5.24\%}$
test_redq_speed[reduce-overhead-backward] 16.5758ms 14.9847ms 66.7349 Ops/s 63.3889 Ops/s $\textbf{\color{#35bf28}+5.28\%}$
test_redq_deprec_speed[False-None] 15.6917ms 13.5356ms 73.8793 Ops/s 63.8213 Ops/s $\textbf{\color{#35bf28}+15.76\%}$
test_redq_deprec_speed[False-backward] 22.0967ms 19.4730ms 51.3530 Ops/s 48.4953 Ops/s $\textbf{\color{#35bf28}+5.89\%}$
test_redq_deprec_speed[True-None] 6.3319ms 5.5713ms 179.4928 Ops/s 171.6554 Ops/s $\color{#35bf28}+4.57\%$
test_redq_deprec_speed[True-backward] 11.2065ms 10.7601ms 92.9357 Ops/s 88.7771 Ops/s $\color{#35bf28}+4.68\%$
test_redq_deprec_speed[reduce-overhead-None] 8.5597ms 5.5795ms 179.2279 Ops/s 169.2675 Ops/s $\textbf{\color{#35bf28}+5.88\%}$
test_redq_deprec_speed[reduce-overhead-backward] 11.5884ms 10.9558ms 91.2762 Ops/s 89.3944 Ops/s $\color{#35bf28}+2.10\%$
test_td3_speed[False-None] 8.9082ms 8.3077ms 120.3710 Ops/s 118.5189 Ops/s $\color{#35bf28}+1.56\%$
test_td3_speed[False-backward] 11.6613ms 10.8776ms 91.9322 Ops/s 89.5308 Ops/s $\color{#35bf28}+2.68\%$
test_td3_speed[True-None] 2.5356ms 2.2987ms 435.0324 Ops/s 427.8819 Ops/s $\color{#35bf28}+1.67\%$
test_td3_speed[True-backward] 4.1059ms 3.9792ms 251.3057 Ops/s 243.2632 Ops/s $\color{#35bf28}+3.31\%$
test_td3_speed[reduce-overhead-None] 2.5196ms 2.3057ms 433.7163 Ops/s 430.5020 Ops/s $\color{#35bf28}+0.75\%$
test_td3_speed[reduce-overhead-backward] 4.2514ms 4.0339ms 247.8961 Ops/s 234.8784 Ops/s $\textbf{\color{#35bf28}+5.54\%}$
test_cql_speed[False-None] 39.6729ms 38.1566ms 26.2078 Ops/s 26.4376 Ops/s $\color{#d91a1a}-0.87\%$
test_cql_speed[False-backward] 49.7693ms 48.1503ms 20.7683 Ops/s 20.5047 Ops/s $\color{#35bf28}+1.29\%$
test_cql_speed[True-None] 24.4084ms 23.1609ms 43.1763 Ops/s 43.5009 Ops/s $\color{#d91a1a}-0.75\%$
test_cql_speed[True-backward] 31.9971ms 30.5943ms 32.6858 Ops/s 33.0741 Ops/s $\color{#d91a1a}-1.17\%$
test_cql_speed[reduce-overhead-None] 24.3705ms 23.1087ms 43.2737 Ops/s 43.6859 Ops/s $\color{#d91a1a}-0.94\%$
test_cql_speed[reduce-overhead-backward] 31.3997ms 30.1099ms 33.2117 Ops/s 32.8935 Ops/s $\color{#35bf28}+0.97\%$
test_a2c_speed[False-None] 7.7829ms 7.4448ms 134.3213 Ops/s 133.1727 Ops/s $\color{#35bf28}+0.86\%$
test_a2c_speed[False-backward] 17.6983ms 14.9404ms 66.9328 Ops/s 66.0848 Ops/s $\color{#35bf28}+1.28\%$
test_a2c_speed[True-None] 6.1825ms 4.8609ms 205.7236 Ops/s 201.0007 Ops/s $\color{#35bf28}+2.35\%$
test_a2c_speed[True-backward] 12.5021ms 11.8555ms 84.3487 Ops/s 84.9098 Ops/s $\color{#d91a1a}-0.66\%$
test_a2c_speed[reduce-overhead-None] 5.3161ms 4.8680ms 205.4243 Ops/s 210.3779 Ops/s $\color{#d91a1a}-2.35\%$
test_a2c_speed[reduce-overhead-backward] 12.3103ms 11.7237ms 85.2974 Ops/s 84.8996 Ops/s $\color{#35bf28}+0.47\%$
test_ppo_speed[False-None] 9.5425ms 7.7939ms 128.3052 Ops/s 126.5970 Ops/s $\color{#35bf28}+1.35\%$
test_ppo_speed[False-backward] 16.7742ms 15.5035ms 64.5015 Ops/s 64.4355 Ops/s $\color{#35bf28}+0.10\%$
test_ppo_speed[True-None] 5.8218ms 5.2932ms 188.9228 Ops/s 193.6185 Ops/s $\color{#d91a1a}-2.43\%$
test_ppo_speed[True-backward] 12.4702ms 11.5525ms 86.5615 Ops/s 85.3643 Ops/s $\color{#35bf28}+1.40\%$
test_ppo_speed[reduce-overhead-None] 6.5900ms 5.2860ms 189.1796 Ops/s 191.9261 Ops/s $\color{#d91a1a}-1.43\%$
test_ppo_speed[reduce-overhead-backward] 12.5612ms 11.6789ms 85.6243 Ops/s 85.6612 Ops/s $\color{#d91a1a}-0.04\%$
test_reinforce_speed[False-None] 7.7111ms 6.7082ms 149.0712 Ops/s 147.6582 Ops/s $\color{#35bf28}+0.96\%$
test_reinforce_speed[False-backward] 12.0497ms 10.3699ms 96.4329 Ops/s 96.7509 Ops/s $\color{#d91a1a}-0.33\%$
test_reinforce_speed[True-None] 4.9288ms 4.2873ms 233.2496 Ops/s 237.4895 Ops/s $\color{#d91a1a}-1.79\%$
test_reinforce_speed[True-backward] 11.3188ms 10.4702ms 95.5089 Ops/s 92.7095 Ops/s $\color{#35bf28}+3.02\%$
test_reinforce_speed[reduce-overhead-None] 4.9897ms 4.1310ms 242.0740 Ops/s 234.8334 Ops/s $\color{#35bf28}+3.08\%$
test_reinforce_speed[reduce-overhead-backward] 10.9469ms 10.2236ms 97.8131 Ops/s 92.3822 Ops/s $\textbf{\color{#35bf28}+5.88\%}$
test_iql_speed[False-None] 36.7132ms 33.1923ms 30.1275 Ops/s 29.2703 Ops/s $\color{#35bf28}+2.93\%$
test_iql_speed[False-backward] 48.7637ms 46.5154ms 21.4982 Ops/s 21.0896 Ops/s $\color{#35bf28}+1.94\%$
test_iql_speed[True-None] 17.5129ms 16.0842ms 62.1728 Ops/s 59.8820 Ops/s $\color{#35bf28}+3.83\%$
test_iql_speed[True-backward] 28.6767ms 27.4990ms 36.3650 Ops/s 34.9826 Ops/s $\color{#35bf28}+3.95\%$
test_iql_speed[reduce-overhead-None] 17.3119ms 16.1497ms 61.9207 Ops/s 60.3882 Ops/s $\color{#35bf28}+2.54\%$
test_iql_speed[reduce-overhead-backward] 29.3341ms 27.5792ms 36.2592 Ops/s 35.3975 Ops/s $\color{#35bf28}+2.43\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.3520ms 4.8956ms 204.2632 Ops/s 198.7613 Ops/s $\color{#35bf28}+2.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7737ms 0.5455ms 1.8333 KOps/s 1.8031 KOps/s $\color{#35bf28}+1.68\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8510ms 0.5230ms 1.9120 KOps/s 1.8171 KOps/s $\textbf{\color{#35bf28}+5.22\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.1750ms 4.7129ms 212.1819 Ops/s 206.0702 Ops/s $\color{#35bf28}+2.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0760ms 0.5443ms 1.8374 KOps/s 1.8388 KOps/s $\color{#d91a1a}-0.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8088ms 0.5116ms 1.9547 KOps/s 1.9045 KOps/s $\color{#35bf28}+2.64\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.4747ms 1.7302ms 577.9767 Ops/s 573.6784 Ops/s $\color{#35bf28}+0.75\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.7856ms 1.6426ms 608.7856 Ops/s 611.3425 Ops/s $\color{#d91a1a}-0.42\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.4195ms 4.7712ms 209.5894 Ops/s 199.8678 Ops/s $\color{#35bf28}+4.86\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0760ms 0.6876ms 1.4544 KOps/s 1.4324 KOps/s $\color{#35bf28}+1.54\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0496ms 0.6623ms 1.5098 KOps/s 1.4565 KOps/s $\color{#35bf28}+3.66\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.4526ms 4.6553ms 214.8101 Ops/s 196.4347 Ops/s $\textbf{\color{#35bf28}+9.35\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1412ms 0.5510ms 1.8149 KOps/s 1.7779 KOps/s $\color{#35bf28}+2.08\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7541ms 0.5227ms 1.9131 KOps/s 1.8266 KOps/s $\color{#35bf28}+4.74\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.5465ms 4.6898ms 213.2297 Ops/s 203.2056 Ops/s $\color{#35bf28}+4.93\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8448s 1.7725ms 564.1829 Ops/s 1.8257 KOps/s $\textbf{\color{#d91a1a}-69.10\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7873ms 0.5128ms 1.9501 KOps/s 1.9038 KOps/s $\color{#35bf28}+2.43\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.1826ms 4.8897ms 204.5100 Ops/s 198.4373 Ops/s $\color{#35bf28}+3.06\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3324ms 0.6877ms 1.4542 KOps/s 1.4197 KOps/s $\color{#35bf28}+2.43\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9978ms 0.6642ms 1.5057 KOps/s 1.5073 KOps/s $\color{#d91a1a}-0.11\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 5.8284ms 4.3452ms 230.1367 Ops/s 235.4069 Ops/s $\color{#d91a1a}-2.24\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 8.9032ms 2.4445ms 409.0744 Ops/s 436.3256 Ops/s $\textbf{\color{#d91a1a}-6.25\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.5661ms 1.4164ms 706.0358 Ops/s 748.2658 Ops/s $\textbf{\color{#d91a1a}-5.64\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 10.7899ms 4.4838ms 223.0262 Ops/s 243.4490 Ops/s $\textbf{\color{#d91a1a}-8.39\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 5.1491ms 2.3382ms 427.6846 Ops/s 440.5296 Ops/s $\color{#d91a1a}-2.92\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.4305ms 1.4443ms 692.3719 Ops/s 741.5008 Ops/s $\textbf{\color{#d91a1a}-6.63\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.7807s 19.9848ms 50.0381 Ops/s 22.2354 Ops/s $\textbf{\color{#35bf28}+125.04\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 7.7502ms 2.4774ms 403.6537 Ops/s 372.3131 Ops/s $\textbf{\color{#35bf28}+8.42\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.0916ms 1.3945ms 717.0829 Ops/s 629.4877 Ops/s $\textbf{\color{#35bf28}+13.92\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 63.8732ms 49.8482ms 20.0609 Ops/s 19.8132 Ops/s $\color{#35bf28}+1.25\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 15.3927ms 14.3184ms 69.8401 Ops/s 70.1010 Ops/s $\color{#d91a1a}-0.37\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 62.3691ms 49.5844ms 20.1676 Ops/s 19.8771 Ops/s $\color{#35bf28}+1.46\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 17.1556ms 14.5646ms 68.6594 Ops/s 69.0971 Ops/s $\color{#d91a1a}-0.63\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 64.8220ms 50.4595ms 19.8179 Ops/s 19.9748 Ops/s $\color{#d91a1a}-0.79\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 22.2261ms 15.8751ms 62.9916 Ops/s 63.6520 Ops/s $\color{#d91a1a}-1.04\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] "NameError: name 'gc' is not defined" in "Using Replay Buffers" tutorial

2 participants

@vmoens @facebook-github-bot