Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Apr 23, 2025

[ghstack-poisoned]
This was referenced Apr 23, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2917

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit 1dc7af3 with merge base 48c3e59 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens pushed a commit that referenced this pull request Apr 23, 2025
ghstack-source-id: e27e38d
Pull Request resolved: #2917
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Apr 23, 2025
ghstack-source-id: fafca42
Pull Request resolved: #2917
Vincent Moens added 8 commits April 23, 2025 11:41
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Apr 24, 2025
[ghstack-poisoned]
@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Apr 24, 2025
@vmoens
Copy link
Collaborator Author

vmoens commented Apr 24, 2025

cc @matteobettini This may affect you:
As announced, for consistency across all envs that have nested reward / actions we now enforce that env.action_spec returns the full action spec if the action key is nested. To get the leaf, you need to do env.full_action_spec[env.action_key].

The reason this is needed is because env.action_spec assigns the spec to the action key "action" so we have a discrepancy between getter and setter which isn't great!

Vincent Moens added 2 commits April 24, 2025 10:41
[ghstack-poisoned]
[ghstack-poisoned]
@vmoens vmoens merged commit 1dc7af3 into gh/vmoens/133/base Apr 24, 2025
54 of 70 checks passed
vmoens pushed a commit that referenced this pull request Apr 24, 2025
ghstack-source-id: 690a9f6
Pull Request resolved: #2917
@vmoens vmoens deleted the gh/vmoens/133/head branch April 24, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Deprecation Environments Adds or modifies an environment wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants