Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Write/read space group number to/from orix HDF5, update tests #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnjohnstone merged 1 commit into from
Aug 19, 2020
Merged

Write/read space group number to/from orix HDF5, update tests #106

dnjohnstone merged 1 commit into from
Aug 19, 2020

Conversation

@hakonanes
Copy link
Member

@hakonanes hakonanes commented Aug 19, 2020 •
edited
Loading

Signed-off-by: Håkon Wiik Ånes [email protected]

  • Write a phase's space group number to the crystal map orix HDF5 file
  • Read a phase's space group number from the crystal map orix HDF5 file
  • Update tests

I've checked locally that a file written with orix v0.3 is readable after this change.

@hakonanes hakonanes added the enhancement New feature or request label Aug 19, 2020
@hakonanes hakonanes added this to the v0.4.0 milestone Aug 19, 2020
@hakonanes hakonanes mentioned this pull request Aug 19, 2020
Closed
4 tasks
pc494
pc494 approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@pc494 pc494 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

edit: except for the lost coverage! Teaches me for being too quick on review

@hakonanes
Copy link
Member Author

hakonanes commented Aug 19, 2020

I ran test coverage locally, it showed 100%... Will have a look before this is merged.

@hakonanes
Copy link
Member Author

hakonanes commented Aug 19, 2020

Yeah, apparently only the coverage in the Python 3.8 on Linux build didn't go to 100%...

@hakonanes
Copy link
Member Author

hakonanes commented Aug 19, 2020

Coverage report:

@hakonanes
Copy link
Member Author

hakonanes commented Aug 19, 2020

Don't know why coverage is not 100% on 3.8. Locally I run 3.8.5 from conda on Ubuntu 20.04 myself. Pretty sure it's a one time thing.

@dnjohnstone dnjohnstone merged commit ba6dab6 into pyxem:master Aug 19, 2020
@hakonanes hakonanes deleted the write-read-space-group-to-hdf5 branch August 19, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pc494 pc494 pc494 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

v0.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hakonanes @pc494 @dnjohnstone