Add spherical coordinate attributes to Vector3d, plus Vector3d.to_polar() #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Member
|
In the short term I prefer |
pc494
requested changes
Aug 26, 2020
Member
pc494
left a comment
There was a problem hiding this comment.
Conventions and docstrings, I think we are using "ISO 31-11" - see https://mathworld.wolfram.com/SphericalCoordinates.html
…rdinates-to-vector3d
Signed-off-by: Håkon Wiik Ånes <[email protected]>
pc494
approved these changes
Aug 27, 2020
Member
|
Merging, we scan (and probably should) consider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Håkon Wiik Ånes [email protected]
See #115 for brief motivation. Closes #115.
Vector3d.theta,Vector3d.phiandVector3d.rattributes.Vector3d.to_polar()method to returntheta,phiandr. The method takes no parameters.Written simple tests, which pass. Coverage remains at 100%.
Todo:
polar()function defined outside ofVector3d, so this could be used elsewhere? If so, where do you think this should be placed?Vector3d.retc. should returnScalarobjects or numpy arrays. I prefer numpy arrays, since I haven't yet understood the use ofScalar.