Hotfix: DB Query Quotes #631
Conversation
…venience functions for quote choosing, should fix #628
|
I don't think 860 lines is really a "hotfix" it's rebuilding a significant amount of key code. My preference is this goes on top of develop and is tested holistically with develop once merged.. Also need to be very careful with knex/sqlite/mysql version changes, this has caused us significant issues in the past breaking backwards compatibility. |
Nope, most of the changed lines are linting in files that were edited.
If we want to release 0.4 somewhat soon i'm fine with that. The last release is over 2 years old, so I want bugs to be fixed without waiting another year.
Should not be a big problem, because with sqlite3, the actual sqlite3 "server" is included in the npm package, so the compatibility between node package and db file are actually working. We could implement some tests with opening up really old databases though to ensure that they will be processed by the new package. |
…le in old knex version
|
Reduced to really only fix the quoting error and nothing else. Tests fail because of index route error, whose fix is now removed from this branch and added in #635 |
Description
We relied a lot on JavaScript control structures depending on the dbtype, to manually choose the right quotes for our queries. Knex offers some convenience functions like "db.ref()" and Query Bindings, that should automatically choose the right quotes depending on the used database adapter.
This should fix issues where wrong quotes lead to errors like #628 and make our code slightly slimmer and less error prone - although there's a LOT room for improvement
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: