feat: enable markdown editing for the Rich-text field #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group has a "rich text" and "markdown" buttons to chose which editor to display
Making sure RHF registers changes made from the markdown editor. If the value is not updated properly, we can't save directly without toggeling back the rich text editor and manually modifying the input's value. Also, now we don't re-set the rich text editor's html content for every change made in the MD editor. We do it only when switching back to rich text editing mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #286, which was about switching to "markdown mode" when editing content with the rich text field. The feature allows the user to see the resulting markdown, and edit the file like this if they want to, then go back to rich-text mode or just save the file directly.
Note : for when the text is rendered in the markdown editor, I set the bullet list marker to "-" because I assumed that's what people generally use. I left default italics indicator ("_") and ** for bold text (but I personally prefer a single * for italics). Images and tables work as expected. Let me know if something was forgotten.