Fix race condition in Each() #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76b74eb to
aa5dd80
Compare
ashrayjain
commented
Oct 3, 2018
| } else { | ||
| // if metric was not in idToMetricWithTags map, then it is a built-in metric. Trim the prefix since the | ||
| // registry lookup will automatically prepend the prefix. | ||
| metric = r.registry.Get(name) |
Contributor
Author
There was a problem hiding this comment.
this part was redundant
55f4895 to
772aa0f
Compare
772aa0f to
f2a77c1
Compare
gdearment
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit adds a test that consistently panics due to the Each() implementation handling concurrent Unregister calls correctly.
Second commit adds a fix.
This change is