Merged
Conversation
3751104 to
3dec195
Compare
3dec195 to
ee59c05
Compare
Member
|
Thanks for working on this. I added some more changes on top of your changes to the blueprint behavior.
|
ee59c05 to
e044b00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4571 by
warn_on_modificationsfrom blueprint.py so that warnings aren't ignorablerouteandendpointto check places where reregistering would be bad.setupmethodbehavior betweenFlaskandBlueprint#4571Checklist:
(I owe a bunch of these but since is my first change, I'd like to sanity check that I'm on the right path before digging in more if thats ok)
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.