Start adding indent_blocks to the lexer #1456
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@davidism I've given a stab at #178, although I got a little stuck at some more complex nested / inline templates. It would be great if you could let me know if you agree with the direction in general (in which case I'd be happy to continue working on this)! Also, if you have any ideas how to proceed with fixing the failing nested test, let me know. Thank you! |
Author
|
@davidism Any chance to get some feedback on this PR? I'd still be up for continuing the work on it if that's desirable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding a new
indent_blocksenvironment parameter which automatically indents/dedents block contents. This allows us to add indentation to code block contents (which helps readability) while making sure that the output is also indented nicely.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.