Add pathlike support to stream dump #2067
Open
+64
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Path and Pathlike objects to
TemplateStream.dump.My understanding of the existing code is:
write(value: bytes) -> Noneorwritelines(Iterable[bytes]) -> Nonemethod.AttributeError, e.g.AttributeError: 'NoneType' object has no attribute 'write'My change would modify the behavior to:
opencan handle as a file path is a valid file path. This includes the requestedpathlib.Pathand PathLike objects.AttributeErrorwith a slightly more informative messageAttributeError: 'NoneType' object has no attribute 'write' or 'writelines'Possible Breaking Changes (No tests guarantee this functionality):
openis capable of handling.AttributeErrorThis does not address #1983 the only changes to the typing is the inclusion of the full set of types that
openimplements.fixes #2039
Desired Feedback