feat: show caller name, file and line at the same time #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 82.71% 82.83% +0.12%
==========================================
Files 46 46
Lines 12944 12971 +27
==========================================
+ Hits 10706 10745 +39
+ Misses 2238 2226 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cf7d60b to
1cd906c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes
fields.predefined.caller,fields.predefined.caller-file, andfields.predefined.caller-lineoptions independent. They no longer override each other.This may affect how the caller information is displayed if your configuration file has multiple combinations of these settings merged together.
If you get undesired results because of this change, it is recommended to review your configuration file and remove all unnecessary predefined field variants or split the configuration file into multiple files to make them unambiguous, then choose the appropriate one when viewing certain types of log files.
Closes #901