perf(trie): dispatch V2 storage proofs in lexicographical order#21684
Merged
mediocregopher merged 1 commit intoparadigmxyz:mainfrom Feb 2, 2026
Merged
Conversation
mediocregopher
approved these changes
Feb 2, 2026
Member
|
Forgot to do this for V2, good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dispatch_v2_storage_proofs iterates over B256Map in arbitrary order, but storage proofs are consumed in lexicographical order during the account trie walk. This mismatch causes head-of-line blocking. This sorts storage_targets by hashed address before dispatching to align production order with consumption order.
References:
Dispatch: crates/trie/parallel/src/proof_task.rs#L1810
Consumption: crates/trie/parallel/src/proof_task.rs#L1379
Dont think this is low value? All refer to existing patten.