perf: replace RwLock<HashMap/HashSet> with DashMap/DashSet#21692
Merged
perf: replace RwLock<HashMap/HashSet> with DashMap/DashSet#21692
Conversation
Replace RwLock-wrapped collections with DashMap/DashSet for better concurrent access performance: - transaction-pool/blobstore/mem.rs: RwLock<HashMap> -> DashMap - transaction-pool/blobstore/disk.rs: RwLock<HashSet> -> DashSet - net/dns/resolver.rs: RwLock<HashMap> -> DashMap - storage/rpc-provider: RwLock<HashMap> -> DashMap - storage/provider/overlay.rs: Arc<RwLock<HashMap>> -> Arc<DashMap> Note: chain-state/in_memory.rs was not converted as it requires atomic multi-lock acquisition for consistency.
a638909 to
0d37e83
Compare
mediocregopher
approved these changes
Feb 2, 2026
mattsse
approved these changes
Feb 2, 2026
joshieDo
approved these changes
Feb 2, 2026
DaniPopes
added a commit
that referenced
this pull request
Feb 3, 2026
Co-authored-by: Georgios Konstantopoulos <[email protected]> Co-authored-by: joshieDo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace RwLock-wrapped collections with DashMap/DashSet for better concurrent access performance.
Changes
RwLock<HashMap>→DashMapforMapResolverRwLock<HashMap>→DashMapforcode_storecacheArc<RwLock<HashMap>>→Arc<DashMap>for overlay cacheNot Changed
blocksandnumbersmaps, so RwLock is still appropriate here.