Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix for readonly users should not access secrets #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix for readonly users should not access secrets #73

merged 1 commit into from
Aug 10, 2023

Conversation

nirav-rafay
Copy link
Contributor

@nirav-rafay nirav-rafay commented Jul 28, 2023 •
edited
Loading

What does this PR change?

Does the PR depend on any other PRs or Issues? If yes, please list them.

  • No

Checklist

I confirm, that I have...

  • Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using go fmt (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • Updated CHANGELOG.md

@nirav-rafay nirav-rafay linked an issue Jul 28, 2023 that may be closed by this pull request
secret isn't blocked for non-admin user but secrets is #64
Closed
1 task
@niravparikh05 niravparikh05 merged commit fe0694d into main Aug 10, 2023
@niravparikh05 niravparikh05 deleted the issue64 branch August 10, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshay196 akshay196 akshay196 approved these changes

@niravparikh05 niravparikh05 Awaiting requested review from niravparikh05 niravparikh05 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

secret isn't blocked for non-admin user but secrets is

3 participants

@nirav-rafay @akshay196 @niravparikh05