[pull] develop from alicevision:develop #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged` The `textChanged` variable created ambiguity, since `TextFields` already have a `textChanged()` signal. It was thus unclear when the `onTextChanged` slot was triggered. Renaming the `textChanged` property to `exprTextChanged` ensures that `onTextChanged` is only triggered when the content of the text field itself is changed by the user.
…hanged This prevents validating default `evaluatedValue` when the user has not performed any change.
If the `ExpressionTextField` is meant for an integer (`isInt = true`), then the value of the expression should be an integer, meaning rounding may need to be applied. However, for floating numbers, we do not want to lose some precision, so the value should never be rounded or set to a fixed number of decimal digits.
Floating numbers should not have a fixed number of decimals to avoid losing precision, so the `decimals` property is not needed anymore. References to it are removed in the HdrImageToolbar.
[qml] ExpressionTextFields: Fix unwanted value updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? đź’– Please sponsor : )