Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cwebpではなくbimgを使ってwebp変換する #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Drumato merged 11 commits into from
Oct 28, 2024
Merged

cwebpではなくbimgを使ってwebp変換する #19

Drumato merged 11 commits into from
Oct 28, 2024

Conversation

@Drumato
Copy link

@Drumato Drumato commented Apr 10, 2024 •
edited
Loading

外部コマンドでcwebpを使って変換するのではなく、bimg(libvips)で変換するように書き換えました。
Cライブラリを使うためにDockerfileのベースイメージをdistrolessからdebianに変え、 CGO_ENABLED=0 を削除しました。

また、imagingを使って変換していた(webpではない)プロキシも置き換えました

ベンチマーク

従来の方法

BenchmarkProxyJpeg-12                      	      36	  32134368 ns/op	 2732786 B/op	     305 allocs/op
BenchmarkProxyPNG-12                       	     741	   1539859 ns/op	 5365531 B/op	     226 allocs/op
BenchmarkConvJPG2WebP_OldCwebpMethod-12    	      13	  85976654 ns/op	 1777722 B/op	     186 allocs/op

置き換え後
quality指定なし

BenchmarkProxyJpeg-12            	      67	  17042145 ns/op	 3866607 B/op	     249 allocs/op
BenchmarkProxyPNG-12             	     762	   1599133 ns/op	 5365836 B/op	     226 allocs/op
BenchmarkConvJPG2WebP_bimg-12    	      26	  44308845 ns/op	 3308000 B/op	      31 allocs/op

quality指定あり

BenchmarkProxyJpeg-12            	      81	  13760491 ns/op	 4392313 B/op	     247 allocs/op
BenchmarkProxyPNG-12             	     758	   1431104 ns/op	 5362828 B/op	     227 allocs/op
BenchmarkConvJPG2WebP_bimg-12    	      21	  58375780 ns/op	 3381610 B/op	      31 allocs/op

@Drumato Drumato requested a review from takutakahashi April 10, 2024 10:57
Drumato added 8 commits April 11, 2024 09:38
@Drumato
新旧方式でベンチマークを取る
7599e4d 
Signed-off-by: drumato <[email protected]>
@Drumato
webp以外の変換処理もbimg使ってみる
75913bc 
Signed-off-by: drumato <[email protected]>
@Drumato
ベンチマークは取ったので古い方式は削除してimaging依存を消す
fe504ce 
Signed-off-by: drumato <[email protected]>
@Drumato
cwebpを参照している部分はなくなったのでDockerfileからも消してしまう
325d49b 
Signed-off-by: drumato <[email protected]>
@Drumato
cwebpのjpeg_likeなオプションと同じくquality設定してprocessいれる
e92b2c0 
Signed-off-by: drumato <[email protected]>
@Drumato
Revert "cwebpのjpeg_likeなオプションと同じくquality設定してprocessいれる"
c3314ca 
This reverts commit e92b2c0.
@Drumato
Processですべてを処理できるのでbimg.Imageの変換は一回で
bb64faa 
Signed-off-by: drumato <[email protected]>
@Drumato
webp以外は明示的なAutoRotateが必要だった
37858fa 
Signed-off-by: drumato <[email protected]>
takutakahashi
takutakahashi approved these changes Apr 11, 2024
View reviewed changes
Copy link

@takutakahashi takutakahashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Drumato Drumato merged commit 4ba4c30 into master Oct 28, 2024
@Drumato Drumato deleted the use-bimg branch October 28, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takutakahashi takutakahashi takutakahashi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Drumato @takutakahashi