Thanks to visit codestin.com
Credit goes to github.com

Skip to content

req の goroutine が溜まってしまう問題を修正 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
takutakahashi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

req の goroutine が溜まってしまう問題を修正 #27

takutakahashi wants to merge 1 commit into from

Conversation

@takutakahashi
Copy link

@takutakahashi takutakahashi commented Dec 11, 2025

以下の goroutine が大量に溜まっています。
これは close ができていない箇所があることが想定されるので、修正します。

  • 404/403 エラー時も Body がクローズされるように defer を前に移動
  • アイドル接続が90秒後に自動クローズされるようにする
  • webp.go でステータスコードが 200/304 以外の場合に orgRes.Body.Close() を追加
goroutine 3540 [select, 181 minutes]:
net/http.(*persistConn).writeLoop(0xc0001325a0)
        /usr/local/go/src/net/http/transport.go:2593 +0xe7
created by net/http.(*Transport).dialConn in goroutine 3480
        /usr/local/go/src/net/http/transport.go:1948 +0x17a5

goroutine 2210 [select, 181 minutes]:
net/http.(*persistConn).writeLoop(0xc0000d0a20)
        /usr/local/go/src/net/http/transport.go:2593 +0xe7
created by net/http.(*Transport).dialConn in goroutine 2094
        /usr/local/go/src/net/http/transport.go:1948 +0x17a5

goroutine 14604 [select, 177 minutes]:
net/http.(*persistConn).readLoop(0xc0006da5a0)
        /usr/local/go/src/net/http/transport.go:2398 +0xc5f
created by net/http.(*Transport).dialConn in goroutine 14509
        /usr/local/go/src/net/http/transport.go:1947 +0x174f

goroutine 8 [select, 182 minutes]:
net/http.(*persistConn).readLoop(0xc000132240)
        /usr/local/go/src/net/http/transport.go:2398 +0xc5f
created by net/http.(*Transport).dialConn in goroutine 20
        /usr/local/go/src/net/http/transport.go:1947 +0x174f

goroutine 22517 [select, 174 minutes]:
net/http.(*persistConn).readLoop(0xc000fb8a20)
        /usr/local/go/src/net/http/transport.go:2398 +0xc5f
created by net/http.(*Transport).dialConn in goroutine 22491
        /usr/local/go/src/net/http/transport.go:1947 +0x174f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@takutakahashi