Thanks to visit codestin.com
Credit goes to github.com

Skip to content

B2 using s3 aws sdk #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 17, 2022
Merged

B2 using s3 aws sdk #1599

merged 9 commits into from
Jun 17, 2022

Conversation

@kalidor
Copy link
Contributor

@kalidor kalidor commented Mar 17, 2022

This commit allow requesting B2 API directly using s3 code.
See: https://help.backblaze.com/hc/en-us/articles/360047629713-Using-the-AWS-Go-SDK-with-B2

@kalidor kalidor mentioned this pull request Mar 17, 2022
Closed
aviau
aviau reviewed Mar 18, 2022
View reviewed changes
@kalidor
Copy link
Contributor Author

kalidor commented Mar 19, 2022 •
edited
Loading

This commit allow the use of

"b2": "appKey:SecretKey:bucket:endpoint"

This will generate s3 lowlevel configuration for interacting with B2, and it works well.
b2 code (pkg/blobserver/b2) is removed since not used (because not working anymore).

aviau
aviau reviewed Mar 21, 2022
View reviewed changes
aviau
aviau reviewed Mar 21, 2022
View reviewed changes
@aviau
Copy link
Member

aviau commented Mar 21, 2022

Few small nits but otherwise lgtm, thanks for working on this. I'll merge once comments are fixed.

aviau
aviau reviewed Mar 21, 2022
View reviewed changes
@MichaHoffmann
Copy link
Member

MichaHoffmann commented Mar 28, 2022

looks good

@aviau
Copy link
Member

aviau commented Apr 6, 2022

lgtm. I started CI and will merge on success

@aviau
Copy link
Member

aviau commented Apr 6, 2022

Looks like tests are failing! Please fix them and ping me when done.

@kalidor
Fixing tests:
fbef8e3 
* Adding 'vendor' argument to generate configuration.
* Update json testcases
@MichaHoffmann
Copy link
Member

MichaHoffmann commented Apr 21, 2022

Hey @kalidor

are you still working on this? Test failure looks unrelated and just "go mod tidy" missing

@kalidor
Copy link
Contributor Author

kalidor commented Apr 22, 2022

I saw the tests failure. I don't work on this since my last commit. Moreover, I don't know what to do to fix the tests failed...

@MichaHoffmann
Copy link
Member

MichaHoffmann commented Apr 30, 2022

I saw the tests failure. I don't work on this since my last commit. Moreover, I don't know what to do to fix the tests failed...

The test failure is unrelated flakiness in the FUSE thing. I think you could run go mod tidy and commit your changes and then at least the tests/tidy should succeed.

@MichaHoffmann
Copy link
Member

MichaHoffmann commented Apr 30, 2022

I just created a B2 account and will give this a manual test later today!

@MichaHoffmann
Copy link
Member

MichaHoffmann commented Apr 30, 2022

I just created a B2 account and will give this a manual test later today!

Data syncs successfully to B2

@MichaHoffmann MichaHoffmann mentioned this pull request May 1, 2022
Closed
MichaHoffmann
MichaHoffmann approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this for a few weeks now; works as expected

@kalidor kalidor requested a review from aviau June 14, 2022 07:21
@bradfitz bradfitz merged commit ef8cb04 into perkeep:master Jun 17, 2022
@kalidor kalidor deleted the b2_using_s3_aws_sdk branch June 22, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

@aviau aviau Awaiting requested review from aviau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kalidor @aviau @MichaHoffmann @bradfitz