feat: Move scaling to PDFs #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evermore defines values of nuisance / constraint parameters in units of standard deviations of the effect to be applied.
Especially, this is required in the loss computation of the constraint term in
evermore/src/evermore/loss.py
Lines 20 to 28 in 752fb90
This PR generalizes the scaling of the parameter value to the evaluation point x of the PDF which is beneficial in two cases:
I added a new abstract PDF method
scale_std(side note, I'm not sure if that name is optimal yet), which is implemented by both Normal and Poisson. The former does the usual scaling using mean and width, whereas the second one raises an exception, at least until we have a quantile based, differentiable computation (if that exists at all).