This repository was archived by the owner on Aug 17, 2025. It is now read-only.
When the uri have the slash, the next request should also have the slash #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Turns out this is primarily a problem in phly/http, which currently prefixes the path with a "/" if it does not begin with one -- even when empty! Will have a fix for both projects shortly. |
weierophinney
added a commit
to phly/http
that referenced
this pull request
Jan 21, 2015
Merged
Contributor
Author
|
Yes, that was why I opened https://github.com/phly/http/issues/22 . But I was only able to reproduce it at here. |
Contributor
Author
|
Finally I changed it to use as |
harikt
added a commit
to harikt/conduit-skelton
that referenced
this pull request
Jan 22, 2015
mtymek
pushed a commit
to mtymek/http
that referenced
this pull request
May 22, 2015
Paths can be empty. However, previously, a check for the first character not being a slash always prepended a slash -- even when the path was empty. This fixes phly/conduit#27
mtymek
pushed a commit
to mtymek/http
that referenced
this pull request
May 22, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, another case of failure :-) .