Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Removes some remaining hints to ARP flush that were forgotten in #2541


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team as a code owner June 29, 2025 19:52
@DL6ER
Copy link
Member

DL6ER commented Jun 30, 2025

Well, this is a breaking change as you are modifying the API endpoint. There needs to be a related web PR.

@yubiuser
Copy link
Member Author

yubiuser commented Jun 30, 2025

Web: pi-hole/web#3553

@yubiuser
Copy link
Member Author

Core: pi-hole/pi-hole#6319

@DL6ER
Copy link
Member

DL6ER commented Jul 2, 2025

I'm still unsure how we should handle this. It does remove an API endpoint which is unlikely to be used by external scripts but it is also not impossible. We could maybe have both, /api/action/flush/arp and /api/action/flush/network doing the same thing and say the former is deprecated and will be removed in a future release? This mostly shifts the "breaking" issue into the future, however, it does at least give maintainers of such scripts some time for mitigation/migration of their scripts.

@PromoFaux
Copy link
Member

We could maybe have both, /api/action/flush/arp and /api/action/flush/network doing the same thing and say the former is deprecated and will be removed in a future release?

Yep - agree this is the correct way to do it

@yubiuser
Copy link
Member Author

Added /action/flush/arp back and set it to deprecated. I would have expected, the documentation still shows the endpoint but marks it as deprecated. However, it's not shown at all on

https://ftl.pi-hole.net/arp/network/docs/

@yubiuser yubiuser requested a review from DL6ER July 13, 2025 17:38
@PromoFaux
Copy link
Member

. However, it's not shown at all on

???

image image

@yubiuser
Copy link
Member Author

Nice. Must have been a timing issue or browser cache issue.

@DL6ER
Copy link
Member

DL6ER commented Jul 13, 2025

I think this is good to go but I made a few comments on the related core PR. I plan to test this myself over the next days.

@DL6ER
Copy link
Member

DL6ER commented Jul 15, 2025

I think this triad of PRs is ready. However, I see @dschaper labeled the core repo one as waiting for next point release so I am not starting merging here as I'm unsure where we are in the release cycle. I plan to work on the static DHCP thing but I cannot promise when (if) I can finish this soon

@yubiuser
Copy link
Member Author

Core PR pi-hole/pi-hole#6319 has been merged.

@DL6ER DL6ER merged commit c0d441a into development Jul 23, 2025
25 of 26 checks passed
@DL6ER DL6ER deleted the arp/network branch July 23, 2025 18:28
@PromoFaux PromoFaux mentioned this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants