-
-
Notifications
You must be signed in to change notification settings - Fork 235
Remove remaining traces of ARP flush #2545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yubiuser <[email protected]>
|
Well, this is a breaking change as you are modifying the API endpoint. There needs to be a related web PR. |
|
Web: pi-hole/web#3553 |
|
Core: pi-hole/pi-hole#6319 |
|
I'm still unsure how we should handle this. It does remove an API endpoint which is unlikely to be used by external scripts but it is also not impossible. We could maybe have both, |
Yep - agree this is the correct way to do it |
Signed-off-by: yubiuser <[email protected]>
|
Added |
|
Nice. Must have been a timing issue or browser cache issue. |
|
I think this is good to go but I made a few comments on the related core PR. I plan to test this myself over the next days. |
|
I think this triad of PRs is ready. However, I see @dschaper labeled the core repo one as waiting for next point release so I am not starting merging here as I'm unsure where we are in the release cycle. I plan to work on the static DHCP thing but I cannot promise when (if) I can finish this soon |
|
Core PR pi-hole/pi-hole#6319 has been merged. |
What does this PR aim to accomplish?:
Removes some remaining hints to ARP flush that were forgotten in #2541
By submitting this pull request, I confirm the following:
git rebase)