Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 9, 2025

What does this implement/fix?

As the prefix is stripped away by the proxy, we shouldn't check for it when deciding if we need to authenticate.


Related issue or feature (if applicable): #2596

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories development branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…iding if we need to authenticate

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested a review from a team as a code owner August 9, 2025 08:00
@DL6ER DL6ER added the Bugfix label Aug 9, 2025
@DL6ER
Copy link
Member Author

DL6ER commented Aug 9, 2025

Confirmed working by OP in #2596

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

Conflicts have been resolved.

@DL6ER DL6ER merged commit 948b97c into development Aug 9, 2025
18 checks passed
@DL6ER DL6ER deleted the fix/webprefix branch August 9, 2025 17:30
@PromoFaux PromoFaux mentioned this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle button in "All Settings" is wrongly displayed after saving, when webserver.paths.prefix is set.

3 participants