Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 7, 2025

What does this implement/fix?

If webserver.serve_all is true, we should not enforce authentication for Lua pages outside of webhome


Related issue or feature (if applicable): https://discourse.pi-hole.net/t/allow-unauthenticated-access-to-non-admin-lua-pages/80464

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

DL6ER added 2 commits June 7, 2025 12:10
… for Lua pages outside of webhome

Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested a review from a team as a code owner June 7, 2025 10:24
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/allow-unauthenticated-access-to-non-admin-lua-pages/80464/7

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working by OP on discourse

@DL6ER DL6ER merged commit 9e520fe into development Jun 8, 2025
18 checks passed
@DL6ER DL6ER deleted the tweak/server_all_no_auth branch June 8, 2025 18:44
@DL6ER DL6ER mentioned this pull request Jun 9, 2025
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v6-2-3-released/80593/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants