Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Try to use the CLI password for logins #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DL6ER merged 3 commits into from
Jun 30, 2024
Merged

Try to use the CLI password for logins #392

DL6ER merged 3 commits into from
Jun 30, 2024

Conversation

@DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 20, 2024

What does this implement/fix?

This PR accompanies PR pi-hole/FTL#1999

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team June 20, 2024 17:45
@DL6ER DL6ER mentioned this pull request Jun 20, 2024
Merged
5 tasks
rdwebdesign
rdwebdesign requested changes Jun 21, 2024
View reviewed changes
@PromoFaux
Copy link
Member

PromoFaux commented Jun 22, 2024

Tested with and without webserver.api.cli_pw enabled

disabled = prompts for password and then works
enabled = works without password prompt

👍

Happy to approve once suggestions resolved

@DL6ER DL6ER requested review from PromoFaux and rdwebdesign June 22, 2024 18:52
yubiuser
yubiuser requested changes Jun 29, 2024
View reviewed changes
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase on latest PADD_FTLv6.
I noticed that the status codes in DeleteSession do not match them in #247 and the current documentation https://ftl.pi-hole.net/development-v6/docs/#delete-/auth

@DL6ER
Copy link
Member Author

DL6ER commented Jun 29, 2024

Sure, this PR would only merge the diff, so it doesn't matter but I rebased nonetheless.

@DL6ER DL6ER merged commit a0054e8 into PADD_FTLv6 Jun 30, 2024
@DL6ER DL6ER deleted the new/cli_pw branch June 30, 2024 18:26
@yubiuser yubiuser mentioned this pull request Feb 13, 2025
Closed
This was referenced Feb 15, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdwebdesign rdwebdesign rdwebdesign approved these changes

@PromoFaux PromoFaux PromoFaux approved these changes

@yubiuser yubiuser yubiuser approved these changes

Assignees

No one assigned

Labels

Pi-hole v6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DL6ER @PromoFaux @rdwebdesign @yubiuser