Conversation
Signed-off-by: RD WebDesign <[email protected]>
yubiuser
referenced
this pull request
May 28, 2023
Signed-off-by: Christian König <[email protected]>
PromoFaux
approved these changes
May 28, 2023
DL6ER
approved these changes
May 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?
Fixing an issue where some Top List items where empty.
How does this PR accomplish the above?
The issue was caused by a recent PR, where every negative expression use in comparisons where changed to positive comparisons. This reversed the logic for many
if-elseblocks, but one was forgotten.This PR fixes the forgotten code.
Link documentation PRs if any are needed to support this PR:
none
By submitting this pull request, I confirm the following:
git rebase)