Fix key handling for windows on Mac/Wpf #2757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wpf: Key events should fire on Window even if there are menu items with the shortcut
e26621e to
7b0bd0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac: Fix certain shortcuts when handling the Window.TextInput events
Wpf: Key events should fire on Window even if there are menu items with the shortcut
On Mac, handling the TextInput event on a Form/Dialog would make certain keyboard shortcuts not fire even if they were defined in the menu.
On Wpf, KeyDown was not firing on the Window before the menu shortcuts.