Added user-quota as server config #464
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 67.43% 67.97% +0.54%
==========================================
Files 43 43
Lines 3083 3126 +43
==========================================
+ Hits 2079 2125 +46
+ Misses 843 840 -3
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
8dde089 to
4d67dd7
Compare
|
@rg0now , would you able to review this change? |
|
This functionality is also covered by #423, which is on top of the general event handler API proposed in #419. Can you please clarify the relation of this PR with those ones, if any? In general, I'm not against merging PRs that implement useful functionality in piecemeal deltas instead of the larger PRs (like the event handler as of #419) which are always much more difficult to get merged. That being said, if there's any chance for the event handler API to get merged in a timely fashion then I'd drop this PR and go with the more generic approach in #423. |
|
Thanks @rg0now , please follow up to get those MRs merged, accordingly I can update this MR. |
|
both PRs finally got merged :) |
|
@rg0now Should we release the next version as v4.1.0 or just v4.0.3? I'd lean toward bumping the minor version and going with v4.1.0. |
|
@JoeTurki I don't have strong opinions on versioning, anything greater than the current will work...:-) As per this PR: I think it would be extremely useful to re-implement this on top of #419 and #423 (just track the number of allocations per user via the |
Released as v4.1.0 :) |
Description
user-quota config added for managing turn allocations counts per turn creds
Reference issue
This MR introduces user quota functionality to restrict the number of allocations per TURN credentials, similar to coturn's user-quota configuration. The implementation allows end users to set allocation limits per credential, preventing resource exhaustion attacks and unauthorized usage. This enhancement improves security posture by limiting potential abuse while providing feature parity with coturn's quota system. The quota configuration is integrated into the existing credential validation flow, ensuring seamless operation with minimal performance impact.