Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i rewrote the complete Pimcore_Event class internals. The class has the same "interface".
Here are some Benchmarks running on my Workstation:
my
Benchmark testRegisterBenchmark took 0.29848313331604 seconds
Benchmark testRegisterCallBenchmark took 0.6698169708252 seconds
Benchmark testCallBenchmark took 0.10555219650269 seconds
Benchmark testUnregisterBenchmark took 0.75062298774719 seconds
Pimcore
Benchmark testRegisterBenchmark took 35.438072919846 seconds
Benchmark testRegisterCallBenchmark took 36.156630992889 seconds
Benchmark testCallBenchmark took 0.1464319229126 seconds
Benchmark testUnregisterBenchmark took 73.74832201004 seconds
i also changed that you cant register 2 events with the same priority.
here are all tests incl. 2 functions to show the difference between both implementations (testImprovement*)
i would like to add the tests to the main code but the current implementation of the tests confused me.