Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug, EC]: Fix translations in workflows #17252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 16, 2024
Merged

[Bug, EC]: Fix translations in workflows #17252

merged 6 commits into from
Jul 16, 2024

Conversation

@kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Jul 1, 2024 •
edited
Loading

Changes in this pull request

Resolves #17150

Additional info

as a bugfix should work, but ideally needs to be moved to admin ui bundle and do as 383741a

@kingjia90 kingjia90 added this to the 11.2.7 milestone Jul 1, 2024
@kingjia90 kingjia90 added the Bug label Jul 1, 2024
@github-actions
Copy link

github-actions bot commented Jul 1, 2024

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 marked this pull request as draft July 1, 2024 09:10
@kingjia90 kingjia90 mentioned this pull request Jul 1, 2024
Closed
@kingjia90 kingjia90 force-pushed the fix-workflow-translation branch from 5a745b2 to 58a9e09 Compare July 1, 2024 10:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@herbertroth herbertroth modified the milestones: 11.2.7, 11.3.1 Jul 2, 2024
@herbertroth herbertroth changed the base branch from 11.2 to 11.3 July 2, 2024 12:25
@kingjia90 kingjia90 marked this pull request as ready for review July 3, 2024 06:31
@ghost ghost added the Pimcore:ToDo label Jul 4, 2024
@kingjia90 kingjia90 merged commit 3ecd39f into 11.3 Jul 16, 2024
@kingjia90 kingjia90 deleted the fix-workflow-translation branch July 16, 2024 10:02
@kingjia90 kingjia90 self-assigned this Jul 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
@kingjia90 kingjia90 linked an issue Jul 16, 2024 that may be closed by this pull request
[Bug, EC]: Missing translations in workflows #17150
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kingjia90 kingjia90

Labels

Bug Pimcore:ToDo

Projects

None yet

Milestone

11.3.1

Development

Successfully merging this pull request may close these issues.

[Bug, EC]: Missing translations in workflows

3 participants

@kingjia90 @herbertroth