Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add getFilterConditionExt for ReverseObjectRelation. #18036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 22, 2025
Merged

Add getFilterConditionExt for ReverseObjectRelation. #18036

merged 17 commits into from
Aug 22, 2025

Conversation

@cancan101
Copy link
Contributor

@cancan101 cancan101 commented Jan 29, 2025 •
edited
Loading

Looking for initial feedback on the approach here.

The idea is that with this logic we can enable filtering on reverse relationships from the admin-ui (ie revert: pimcore/admin-ui-classic-bundle#375).

Changes in this pull request

Follow up to #16273
/CC @kingjia90 @wisconaut

Additional info

@github-actions
Copy link

Review Checklist

  • Target branch (11.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@cancan101 cancan101 force-pushed the feature/reverse-filtering branch from 6076779 to f2f38a0 Compare March 5, 2025 06:48
@cancan101 cancan101 marked this pull request as ready for review March 6, 2025 06:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ghost ghost added the Pimcore:ToDo label Mar 11, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
2 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cancan101 cancan101 mentioned this pull request Jul 9, 2025
Merged
@fashxp
Copy link
Member

fashxp commented Jul 10, 2025

sorry for the late response. is that still relevant for you. not sure we are able to invest too much effort in that since we are in the process of sun setting admin-ui-classic.

@cancan101
Copy link
Contributor Author

we are definitely using this with a local patch.

fashxp
fashxp requested changes Jul 15, 2025
View reviewed changes
cancan101
cancan101 commented Jul 26, 2025
View reviewed changes
@robertSt7 robertSt7 self-assigned this Aug 12, 2025
@robertSt7
Copy link
Contributor

@cancan101 Since we need this for the other in the admin-ui. Could you please take care of this within the next week?
After that period, we may need to close the PR, as we aren't accept contributions for admin-ui longer. We appreciate your understanding.

@cancan101 cancan101 requested a review from fashxp August 12, 2025 22:02
@cancan101 cancan101 force-pushed the feature/reverse-filtering branch from 9f2f364 to a03c856 Compare August 12, 2025 22:21
@fashxp fashxp requested a review from robertSt7 August 18, 2025 10:48
fashxp
fashxp requested changes Aug 18, 2025
View reviewed changes
@cancan101 cancan101 requested a review from fashxp August 20, 2025 01:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 20, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fashxp
fashxp approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@fashxp fashxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@fashxp fashxp added this to the 12.2.0 milestone Aug 22, 2025
@fashxp fashxp changed the base branch from 11.5 to 12.x August 22, 2025 10:20
@fashxp fashxp changed the base branch from 12.x to 11.5 August 22, 2025 10:20
@fashxp fashxp changed the base branch from 11.5 to 12.x August 22, 2025 11:18
@fashxp
Copy link
Member

fashxp commented Aug 22, 2025

thx very much.

@fashxp fashxp merged commit 87b9b16 into pimcore:12.x Aug 22, 2025
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fashxp fashxp fashxp approved these changes

@robertSt7 robertSt7 Awaiting requested review from robertSt7

Assignees

@robertSt7 robertSt7

Labels

Improvement Pimcore:ToDo

Projects

None yet

Milestone

12.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cancan101 @fashxp @robertSt7