Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Improvement]: MaintenanceModeHelper::isActive rely on cache instead of database directly #18166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 21, 2025
Merged

[Improvement]: MaintenanceModeHelper::isActive rely on cache instead of database directly #18166

merged 8 commits into from
Jul 21, 2025

Conversation

@kingjia90
Copy link
Contributor

Changes in this pull request

Resolves #17640

Additional info

@github-actions
Copy link

github-actions bot commented Mar 3, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 force-pushed the maintenance-cache branch from aefa292 to d50fe04 Compare March 3, 2025 16:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ghost ghost assigned markus-moser Mar 4, 2025
@herbertroth herbertroth requested a review from markus-moser March 4, 2025 08:15
@ghost ghost added the Pimcore:ToDo label Mar 13, 2025
@kingjia90 kingjia90 added this to the 12.1.0 milestone May 26, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fashxp
Copy link
Member

fashxp commented Jun 18, 2025

@kingjia90 how should we proceed with that one? 2025.2?

@kingjia90
Copy link
Contributor Author

I'd say it's safe to be merged (code-wise is just adding some caching things), just not sure if it fully addresses the reported issue but shouldn't be there any side-effects

@herbertroth herbertroth modified the milestones: 12.1.0, 12.2.0 Jun 30, 2025
@kingjia90 kingjia90 force-pushed the maintenance-cache branch from 13f07e7 to 626f718 Compare July 18, 2025 14:43
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kingjia90
kingjia90 commented Jul 18, 2025
View reviewed changes
lib/Tool/MaintenanceModeHelper.php
return $entryId === self::OFF ? null : $entryId;
}

// The cache entry is not set, we try to load it from the database
Copy link
Contributor Author

@kingjia90 kingjia90 Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is that the Cache::load() returns false when the entry is not existing. We involve the TmpStore from here and below (like as a fallback).

We set instead to a OFF string and check that to skip any DB/TmpStore calls.

Would it be a good solution?

@kingjia90 kingjia90 removed the request for review from markus-moser July 21, 2025 15:45
@kingjia90 kingjia90 merged commit 789509c into 12.x Jul 21, 2025
13 checks passed
@kingjia90 kingjia90 deleted the maintenance-cache branch July 21, 2025 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kingjia90 kingjia90

Labels

Pimcore:ToDo

Projects

None yet

Milestone

12.2.0

Development

Successfully merging this pull request may close these issues.

[Improvement][Perf]: MaintenanceModeHelper::isActive shouldn't connect to rely on the database directly

5 participants

@kingjia90 @fashxp @markus-moser @herbertroth