Fix: Create asset of correct class type (#16363) #18439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
6e2aece to
14be6d0
Compare
Error: `Asset::create(data: ['type' => 'folder'])` returned a `\Pimcore\Model\Asset\Unknown` instead of `\Pimcore\Model\Asset\Folder` Caused by: The type was only used when detected by the binary file data Resolved with: Adding a type check on the $data array Resolves pimcore#16363
14be6d0 to
91947f0
Compare
|
mcop1
approved these changes
Aug 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #16363
Additional info
Error:
Asset::create(data: ['type' => 'folder'])returned a\Pimcore\Model\Asset\Unknowninstead of\Pimcore\Model\Asset\FolderCaused by: The type was only used when detected by the binary file data
Resolved with: Adding a type check on the $data array
Side effects of bug
The bug caused other effects such as the DataHub Simple Rest API Indexer not being able to process Asset Folders created via the Classic Admin (using
Asset::create) as it checked on the assetinstanceofwithingetEntityTypeForElement( https://github.com/pimcore/data-hub-simple-rest/blob/3.x/src/Service/AbstractService.php#L258 )