never create real unnecessary markup in the document_tags -> frontend methods. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
document/editmail.js overwrote the document.edit. both files are now bin...
… method. for example we had a lot of pain if we wanted to create pdf's using a html2pdf converter because of this div tag. so if someone wants to have such an html element, he can create it in the view. pimcore specific markup must not be displayed in the content!
|
this can cause problems with existing installations where this DIV are formatted using stylesheets, so I don't think that this is a good idea. |
|
what do you think about using a flag to activate / deactivate this? i think there must be a way to disable pimcore specific html markup in the frontend method. in my opinion somebody who styled a class called "pimcore" for the frontend, should had known that this cant be good. |
pimcore-deployments
pushed a commit
that referenced
this pull request
Dec 18, 2023
… a requirement on the settings-store when building the PHP classes of class definitions (#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example we had a lot of pain if we wanted to create pdf's using a html2pdf converter because of this div tag.
so if someone wants to have such an html element, he can create it in the view. pimcore specific markup must not be displayed in the content!