Fix PhpDocs (Noticed with PhpStan Level 5) #11828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a6309e to
c721822
Compare
c721822 to
0cae258
Compare
jdreesen
reviewed
Apr 4, 2022
bundles/EcommerceFrameworkBundle/CartManager/CartCheckoutData.php
Outdated
Show resolved
Hide resolved
bundles/EcommerceFrameworkBundle/CartManager/CartCheckoutData/Dao.php
Outdated
Show resolved
Hide resolved
bundles/EcommerceFrameworkBundle/CartManager/CartItemInterface.php
Outdated
Show resolved
Hide resolved
dvesh3
reviewed
Apr 12, 2022
bundles/EcommerceFrameworkBundle/CartManager/AbstractCartItem.php
Outdated
Show resolved
Hide resolved
bundles/EcommerceFrameworkBundle/Model/AbstractFilterDefinition.php
Outdated
Show resolved
Hide resolved
bundles/EcommerceFrameworkBundle/Model/AbstractFilterDefinition.php
Outdated
Show resolved
Hide resolved
dvesh3
reviewed
Apr 12, 2022
bundles/AdminBundle/Controller/Admin/Document/SnippetController.php
Outdated
Show resolved
Hide resolved
dvesh3
reviewed
Apr 12, 2022
|
@dvesh3 Thanks for review. I commented/changed all suggestions. Can you look again? |
LGTM. thanks! |
dvesh3
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix only PhpDocs for branch 10.3.
Splitting up from #11826
Fix 129 PhpStan level 5 errors.