Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix CKEditor: Tables in new created areabricks have no border #11886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2022
Merged

Fix CKEditor: Tables in new created areabricks have no border #11886

merged 2 commits into from
Apr 13, 2022

Conversation

@blankse
Copy link
Contributor

@blankse blankse commented Apr 11, 2022 •
edited
Loading

Fix #11879

The line Ext.get(this.textarea).removeCls("empty"); removes all css classes from CKEditor because ExtJs cache the class names.

@kingjia90 kingjia90 assigned kingjia90 and unassigned kingjia90 Apr 11, 2022
@kingjia90 kingjia90 linked an issue Apr 11, 2022 that may be closed by this pull request
[Bug]: CKEditor: Tables in new created areabricks have no border #11879
Closed
@blankse
Copy link
Contributor Author

blankse commented Apr 13, 2022

@brusch @dvesh3 Can this be part of 10.3.5? Think there are more bugs with the editor in documents. Pimcore remove all css classes after first change.

@kingjia90 kingjia90 added this to the 10.3.5 milestone Apr 13, 2022
@dvesh3 dvesh3 added the Bug label Apr 13, 2022
@dvesh3 dvesh3 self-assigned this Apr 13, 2022
@dvesh3
Copy link
Contributor

dvesh3 commented Apr 13, 2022

LGTM. thanks!

@dvesh3 dvesh3 merged commit 676cd53 into pimcore:10.3 Apr 13, 2022
@dvesh3 dvesh3 mentioned this pull request Apr 13, 2022
Closed
@blankse
Copy link
Contributor Author

blankse commented Apr 13, 2022

@dvesh3 Thanks 👍🏼

@blankse blankse deleted the patch-1 branch April 13, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dvesh3 dvesh3

Labels

Bug

Projects

None yet

Milestone

10.3.5

Development

Successfully merging this pull request may close these issues.

[Bug]: CKEditor: Tables in new created areabricks have no border

3 participants

@blankse @dvesh3 @kingjia90