Staticroute::assemble() - urlencode should be used only when $encode == true #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusch
pushed a commit
that referenced
this pull request
Jun 12, 2012
Staticroute::assemble() - urlencode should be used only when $encode == true git-svn-id: http://www.pimcore.org/svn/pimcore/private/core/trunk@1574 1f8fe7d8-47f0-464c-8d0a-336f4953ab05
brusch
pushed a commit
that referenced
this pull request
May 22, 2013
Staticroute::assemble() - urlencode should be used only when $encode == true git-svn-id: http://www.pimcore.org/svn/pimcore/private/core/trunk@1574 1f8fe7d8-47f0-464c-8d0a-336f4953ab05
pimcore-deployments
pushed a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that unconditional usage of urlencode() is a bug. It should be called only when $encode == true, just like in Zend_Controller_Router_Route.