fixes a Bug where Custom Reports are loaded with a wrong reportClass #4627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx very much. could you please sign our CLA so that we can merge your PR. |
|
Hi, the cla should be signed as cla-assistant.io tells me "You have signed the CLA for pimcore/pimcore" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
fixes a Bug where Custom Reports are loaded with a wrong reportClass
Steps to reproduce
Expected
Every report loads with its own configured reportClass
Actual Behaviour
Every report loads with the configured reportClass of the last report
Additional info
The
reportClassinsidetoolbarenricher.jsis read synchronously inside a for loop. The Menu-Item click handler is triggered asynchronously and uses the last setreportClass