Video conversion not working when storing assets in S3 #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BlackbitNeueMedien seems that pimcore/lib/Video/Adapter/Ffmpeg.php Line 161 in c62924c Maybe you can further investigate this ... thanks! |
|
That check is for the destination file, not the video source. But still, you pointed me in the right direction here. Checking with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
Converting videos (and creating video thumbnails) works regardless of the asset storage location.
Actual behavior
When I use S3 as asset store (set up as described in the docs), it is not possible to use the ffmpeg adapter to convert videos or generate video thumbnails. The problem lies with the creation of the ffmpeg cli command. In Video/Adapter/Ffmpeg.php, the path to the file to convert is created as
realpath($this->file), where$this->fileis in the format ofs3://my-bucket/assets/video.mp4. Therealpathcall will then return false, and the resulting command has no input file argument.