Thanks to visit codestin.com
Credit goes to github.com

Skip to content

playground,cluster: respect HOME env variable #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

playground,cluster: respect HOME env variable #2628

merged 2 commits into from
Nov 4, 2025
+8 −12

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 30, 2025

What problem does this PR solve?

Follow-up for #2624

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Tested:

HOME=/tmp/testhome ./bin/tiup mirror set https://tiup-mirrors.pingcap.com

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack October 30, 2025 07:17
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Oct 30, 2025

/cc @xhebox @bb7133

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox October 30, 2025 07:17
@dveeden
Copy link
Contributor Author

dveeden commented Oct 30, 2025

/cc @breezewish

@ti-chi-bot ti-chi-bot bot requested a review from breezewish October 30, 2025 07:20
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 30, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-30 07:50:25.258873475 +0000 UTC m=+1549331.336126045: ☑️ agreed by breezewish.

@xhebox xhebox merged commit 3e70256 into pingcap:master Nov 4, 2025
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@srstack srstack Awaiting requested review from srstack

@bb7133 bb7133 Awaiting requested review from bb7133

@xhebox xhebox Awaiting requested review from xhebox

Assignees

No one assigned

Labels

lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dveeden @breezewish @xhebox