Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ddl-puller: use standard context and pass changefeed, table info #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 14, 2021
Merged

ddl-puller: use standard context and pass changefeed, table info #3020

merged 5 commits into from
Oct 14, 2021

Conversation

@amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Oct 12, 2021

What problem does this PR solve?

Close #2983

What is changed and how it works?

use standard context in ddl puller API, and ensure table ID, and changefeed ID is set in context

Check List

Tests

  • Unit test
  • Integration test

Release note 

Nond

@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Oct 12, 2021
@amyangfei amyangfei added this to the v5.3.0 milestone Oct 12, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2021
@amyangfei amyangfei added the type/bugfix This PR fixes a bug. label Oct 12, 2021
@amyangfei
Copy link
Contributor Author

amyangfei commented Oct 12, 2021

/run-all-tests

@amyangfei
Copy link
Contributor Author

amyangfei commented Oct 12, 2021

/run-integration-tests
/run-kafka-tests

overvenus
overvenus approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2021
@amyangfei
Copy link
Contributor Author

amyangfei commented Oct 13, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2021

This pull request has been accepted and is ready to merge.

Commit hash: 5c7608e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
@amyangfei
Copy link
Contributor Author

amyangfei commented Oct 13, 2021

/run-kafka-tests

@amyangfei
Copy link
Contributor Author

amyangfei commented Oct 14, 2021

/run-kafka-tests

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2021

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor Author

amyangfei commented Oct 14, 2021

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #3020 (d30f182) into master (3c3b915) will decrease coverage by 0.2910%.
The diff coverage is 50.6892%.

@@               Coverage Diff                @@
##             master      #3020        +/-   ##
================================================
- Coverage   57.2251%   56.9340%   -0.2911%     
================================================
  Files           163        188        +25     
  Lines         19453      20731      +1278     
================================================
+ Hits          11132      11803       +671     
- Misses         7261       7760       +499     
- Partials       1060       1168       +108

@ti-chi-bot ti-chi-bot merged commit d2a6a6d into pingcap:master Oct 14, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2021

In response to a cherrypick label: new pull request created: #3042.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2021

In response to a cherrypick label: new pull request created: #3043.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2021

In response to a cherrypick label: new pull request created: #3044.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2021

In response to a cherrypick label: new pull request created: #3045.

ti-chi-bot added a commit that referenced this pull request Oct 14, 2021
@ti-chi-bot
ddl-puller: use standard context and pass changefeed, table info (#3020…
d33e738 
…) (#3042)
ti-chi-bot added a commit that referenced this pull request Oct 14, 2021
@ti-chi-bot
ddl-puller: use standard context and pass changefeed, table info (#3020…
9d3f26f 
…) (#3043)
ti-chi-bot added a commit that referenced this pull request Oct 14, 2021
@ti-chi-bot
ddl-puller: use standard context and pass changefeed, table info (#3020…
f1dd56a 
…) (#3045)
ti-chi-bot added a commit that referenced this pull request Oct 14, 2021
@ti-chi-bot
ddl-puller: use standard context and pass changefeed, table info (#3020…
494b3d9 
…) (#3044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

+1 more reviewer

@ben1009 ben1009 ben1009 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

v5.3.0

Development

Successfully merging this pull request may close these issues.

puller is initialized log can not print the changefeed ID

5 participants

@amyangfei @ti-chi-bot @codecov-commenter @ben1009 @overvenus