Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(cdc): Add defaultvalue integration test #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 7, 2022
Merged

test(cdc): Add defaultvalue integration test #4224

merged 14 commits into from
Jan 7, 2022

Conversation

@maxshuang
Copy link
Contributor

@maxshuang maxshuang commented Jan 5, 2022

What problem does this PR solve?

Issue Number: close #4223

What is changed and how it works?

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 5, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 5, 2022
@okJiang okJiang added the area/ticdc Issues or PRs related to TiCDC. label Jan 5, 2022
@okJiang okJiang changed the title Add defaultvalue integration test test(cdc): Add defaultvalue integration test Jan 5, 2022
@maxshuang
Copy link
Contributor Author

maxshuang commented Jan 5, 2022

/run-integration-test
/run-kafka-integration-test

@maxshuang
Copy link
Contributor Author

maxshuang commented Jan 5, 2022

/run-integration-test
/run-kafka-integration-test
/run-dm-compatibility-test
/run-dm-integration-test

amyangfei
amyangfei reviewed Jan 5, 2022
View reviewed changes
@amyangfei
update Copyright
04c9445 
Co-authored-by: amyangfei <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022 •
edited
Loading

Codecov Report

Merging #4224 (bd2d8d7) into master (08da001) will decrease coverage by 0.0024%.
The diff coverage is 51.5237%.

Flag Coverage Δ
cdc 58.6122% <56.9620%> (-0.0326%) ⬇️
dm 52.2192% <40.5451%> (-0.0354%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4224        +/-   ##
================================================
- Coverage   55.1722%   55.1698%   -0.0025%     
================================================
  Files           485        491         +6     
  Lines         59829      60921      +1092     
================================================
+ Hits          33009      33610       +601     
- Misses        23484      23929       +445     
- Partials       3336       3382        +46

@maxshuang
Copy link
Contributor Author

maxshuang commented Jan 6, 2022

/run-integration-test
/run-kafka-integration-test
/run-dm-compatibility-test
/run-dm-integration-test

@maxshuang
Copy link
Contributor Author

maxshuang commented Jan 6, 2022

/run-kafka-integration-test

@maxshuang maxshuang requested a review from overvenus January 6, 2022 03:48
@maxshuang maxshuang requested a review from amyangfei January 6, 2022 06:30
@maxshuang
Copy link
Contributor Author

maxshuang commented Jan 6, 2022

/run-integration-test
/run-kafka-integration-test
/run-dm-compatibility-test
/run-dm-integration-test

@maxshuang
Copy link
Contributor Author

maxshuang commented Jan 7, 2022

/run-integration-test
/run-kafka-integration-test
/run-dm-compatibility-test
/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit b730d02 into pingcap:master Jan 7, 2022
@maxshuang maxshuang added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2022
Closed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022

In response to a cherrypick label: new pull request created: #4274.

This was referenced Jan 11, 2022
Closed
Closed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022

In response to a cherrypick label: new pull request created: #4275.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022

In response to a cherrypick label: new pull request created: #4276.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2022
Closed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022

In response to a cherrypick label: new pull request created: #4277.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2022
Closed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022

In response to a cherrypick label: new pull request created: #4278.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflow#release-5.4 from head ti-chi-bot:cherry-pick-4224-to-release-5.4: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

@maxshuang maxshuang added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2022
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022

In response to a cherrypick label: new pull request created: #4279.

ti-chi-bot added a commit that referenced this pull request Jan 11, 2022
@ti-chi-bot
test(cdc): Add defaultvalue integration test (#4224) (#4279)
e8acee8 
close #4223
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Jan 20, 2022
@zhaoxinyu
test(cdc): Add defaultvalue integration test (pingcap#4224)
5eaf4f7 
close pingcap#4223
@maxshuang maxshuang mentioned this pull request Jan 24, 2022
Closed
@maxshuang maxshuang mentioned this pull request Feb 8, 2022
Merged
overvenus pushed a commit that referenced this pull request Feb 8, 2022
@overvenus
test(cdc): Add defaultvalue integration test (#4224)
d9af323 
close #4223
@maxshuang maxshuang mentioned this pull request Feb 22, 2022
Merged
overvenus pushed a commit that referenced this pull request Feb 22, 2022
@overvenus
test(cdc): Add defaultvalue integration test (#4224)
98ee360 
close #4223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xPoe 0xPoe 0xPoe approved these changes

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

@overvenus overvenus Awaiting requested review from overvenus

+1 more reviewer

@amyangfei amyangfei amyangfei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add related integration test and test-infra for DefaultValue

6 participants

@maxshuang @ti-chi-bot @codecov-commenter @amyangfei @0xPoe @okJiang