Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DM: fix default physical import mode disk quota #8680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2023
Merged

DM: fix default physical import mode disk quota #8680

merged 1 commit into from
Mar 24, 2023

Conversation

@lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Mar 24, 2023

This PR is a cherry-pick of #8671

What problem does this PR solve?

Issue Number: close #8672

What is changed and how it works?

Modify lightnig's disk quota when we set DM's disk-quota-physical a non-negative value.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Mar 24, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 24, 2023
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Mar 24, 2023
@lichunzhu
Copy link
Contributor Author

lichunzhu commented Mar 24, 2023

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.0@fd2efea). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2ef25de differs from pull request most recent head dcbccc4. Consider uploading reports for the commit dcbccc4 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 65.6516% <0.0000%> (?)
dm 53.4439% <0.0000%> (?)
engine 65.3990% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-7.0      #8680   +/-   ##
================================================
  Coverage               ?   60.4620%           
================================================
  Files                  ?        804           
  Lines                  ?      93940           
  Branches               ?          0           
================================================
  Hits                   ?      56798           
  Misses                 ?      32210           
  Partials               ?       4932

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2023
@lichunzhu
Copy link
Contributor Author

lichunzhu commented Mar 24, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2023

This pull request has been accepted and is ready to merge.

Commit hash: dcbccc4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@ti-chi-bot ti-chi-bot merged commit dfac8e3 into pingcap:release-7.0 Mar 24, 2023
@lichunzhu lichunzhu deleted the fixLightningDefaultValue70 branch March 27, 2023 06:03
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

+1 more reviewer

@sleepymole sleepymole sleepymole approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lichunzhu @ti-chi-bot @codecov-commenter @D3Hunter @sleepymole @VelocityLight