ENH: More comprehensive default value comparison with is_equal
#860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
a5ff42f to
e06291a
Compare
CodSpeed Performance ReportMerging #860 will not alter performanceComparing Summary
|
Collaborator
|
Great idea! However, I need to take another look at the |
Contributor
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match the correct format. Thank you! |
Collaborator
|
I opened and merged #863 which fixes a bug in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @basnijholt, I just realized that you've already implemented the
_utils._is_equalfunctions which also compares more intricate datatypes that are not / should not be compared with just__eq__. I thought I could make this function public and use it in the comparsion of default values (#856) function to have less situations where it fails to compare default values.