Add a check for clobbered packages in overlays #746
Conversation
|
@arthurzam, any idea how we could make it configured inside repository? I suppose that for the time being we can just explicitly add it to ::guru's CI. |
276314d to
9b5e01f
Compare
There was a problem hiding this comment.
@arthurzam, any idea how we could make it configured inside repository? I suppose that for the time being we can just explicitly add it to ::guru's CI.
Look what we used for AcctCheck::load_ids_from_configuration. If current repo doesn't have it enabled, just raise SkipCheck
| return f"package from repository ::{self.repository} clobbered" | ||
|
|
||
|
|
||
| class MasterPackageClobberedCheck(OverlayRepoCheck, OptionalCheck): |
There was a problem hiding this comment.
If you read qa-policy.conf and decide by it, you can drop OptionalCheck
Yeah, but I don't want ad-hoc design for now. Perhaps it would be better to have some kind of |
|
Thinking about it further:
|
You can just add another package to ::master which is package.masked, and have it at ::guru, and nothing in expected.json. If you remove your code which checks masks - you should see result - and fail (since unexpected result), and with your code, everything passes. |
|
Oh nice. Because of previous failures I've been hitting, I thought |
4f86641 to
ac44b4a
Compare
|
Updated. |
deb36bd to
d680cf0
Compare
Add a check that reports if a given package clobbers a package from the master repository. Since this only applies to some repositores (e.g. ::guru), it is optional (disabled by default). Closes: pkgcore#745 Co-authored-by: Arthur Zamarin <[email protected]> Signed-off-by: Michał Górny <[email protected]>
d680cf0 to
0a46565
Compare
Add a check that reports if a given package clobbers a package from the master repository. Since this only applies to some repositores (e.g. ::guru), it is optional (disabled by default).
Closes: #745