Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add uv to frontend shared workflows #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2025
Merged

Add uv to frontend shared workflows #296

merged 2 commits into from
Oct 10, 2025

Conversation

@ericof
Copy link
Member

@ericof ericof commented Oct 10, 2025

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

mauritsvanrees
mauritsvanrees reviewed Oct 10, 2025
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine, I don't think it can break anything. But can you explain why it is needed? Why does the frontend need uv?

@ericof
Copy link
Member Author

ericof commented Oct 10, 2025

This should be fine, I don't think it can break anything. But can you explain why it is needed? Why does the frontend need uv?

There is a branch of cookieplone-templates that will use repoplone to get most repository settings (like add-on name) from repository.toml, which would make the frontend Makefile easier to maintain

fredvd
fredvd approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@fredvd fredvd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, chatted with Erico about the change.

@ericof ericof merged commit 5ea867a into 2.x Oct 10, 2025
1 check passed
@ericof ericof deleted the repoplone-support branch October 10, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees left review comments

@fredvd fredvd fredvd approved these changes

@gforcada gforcada Awaiting requested review from gforcada

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericof @mauritsvanrees @fredvd