This repository was archived by the owner on Aug 29, 2025. It is now read-only.
settings: add variable PLOTLY_CONNECTOR_BASE_URL #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added env variable PLOTLY_CONNECTOR_BASE_URL so that it is possible to customise connectorURL when running inside on-prem. Closes https://github.com/plotly/streambed/issues/11310
scjody
approved these changes
Aug 13, 2018
|
I’m fine with it if Jody is.
…On Mon, Aug 13, 2018 at 08:38 Jody McIntyre ***@***.***> wrote:
***@***.**** approved this pull request.
💃 from me (assuming this is ready for review...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#514 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMbA79o1Om-KgQPj3l9EF7ztW9c6bwzks5uQZ1jgaJpZM4V6uzx>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customise connectorURL when running inside on-prem.
Closes https://github.com/plotly/streambed/issues/11310
@nicolaskruchten @scjody
I've tested the PR locally:
yarn startPLOTLY_CONNECTOR_BASE_URL="https://test/external-data-connector" PLOTLY_CONNECTOR_RUNNING_INSIDE_ON_PREM=true yarn start