Fixed no fontSize definition in Themes and Added Legends property in geo module #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 8, 2019 14:20
Theme: Font Size attribute Bar: Added story to demo fontSize property Geo: Added legends field definition
Theme: Font Size attribute Bar: Added story to demo fontSize property Geo: Added legends field definition
Theme: Font Size attribute Bar: Added story to demo fontSize property Geo: Added legends field definition fmt
plouc
requested changes
Jun 17, 2020
| onMouseMove?: ChoroplethEventHandler | ||
| onMouseLeave?: ChoroplethEventHandler | ||
| onClick?: ChoroplethEventHandler | ||
| legends: Array<{ dataFrom: 'indexes' | 'keys' } & LegendProps> |
Owner
There was a problem hiding this comment.
This package doesn't support dataFrom, the type should be legends: LegendProps[]
|
|
||
| export type Theme = Partial<{ | ||
| background: string | ||
| fontSize: string | 0 |
Owner
There was a problem hiding this comment.
Actually there are other props missing from this definition:
fontFamily: string
textColor: stringIt would be great if you could add them too!
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the fontSize definition and story to make sure it's working as expected.
Added the legend property definition to Geo module.