Fix possible overflow in Window Functions #591
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that the variable `size` is of the type `size_t`, which is an unsigned integer. Passing a negative value leads to an integer overflow, and the requested size is in the order of 2^64 bytes, which is over 10^10 GB, leading to a heap overflow. Calling the window function will now lead to an error (ERROR: allocation size cannot be negative) instead of crashing.
|
thanks much! letting the tests run now |
JerrySievert
pushed a commit
that referenced
this pull request
Jul 5, 2025
* Fix possible heap overflow in Window Functions The issue is that the variable `size` is of the type `size_t`, which is an unsigned integer. Passing a negative value leads to an integer overflow, and the requested size is in the order of 2^64 bytes, which is over 10^10 GB, leading to a heap overflow. Calling the window function will now lead to an error (ERROR: allocation size cannot be negative) instead of crashing. * Add v8 namespace to String usage to fix build errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that the variable
sizeis of the typesize_t, which is an unsigned integer.Passing a negative value leads to an integer overflow, and the requested size is in the order of 2^64 bytes, which is over 10^10 GB, leading to a heap overflow.
Calling the window function will now lead to an error (ERROR: allocation size cannot be negative) instead of crashing.